Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Container image updates #219

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

hawksight
Copy link
Contributor

@hawksight hawksight commented Jan 31, 2024

  • Builder image moved to go 1.21 as per go.mod
  • Runtime image upgraded to alpine 3.19

Hopefully fixes #218.

I ran this locally using:

docker build -t kubestr:local .
kind create cluster --name kubestr
kind load docker-image kubestr:local --name kubestr
go build .
./kubestr fio -n default -s standard -z "10Gi" --image kubestr:local
# and scanned
trivy image kubestr:local

Output:

2024-01-31T09:46:29.777Z	INFO	Vulnerability scanning is enabled
2024-01-31T09:46:29.777Z	INFO	Secret scanning is enabled
2024-01-31T09:46:29.777Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-01-31T09:46:29.777Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.48/docs/scanner/secret/#recommendation for faster secret detection
2024-01-31T09:46:29.779Z	INFO	Detected OS: alpine
2024-01-31T09:46:29.779Z	WARN	This OS version is not on the EOL list: alpine 3.19
2024-01-31T09:46:29.779Z	INFO	Detecting Alpine vulnerabilities...
2024-01-31T09:46:29.780Z	INFO	Number of language-specific files: 1
2024-01-31T09:46:29.780Z	INFO	Detecting gobinary vulnerabilities...

kubestr:local (alpine 3.19.1)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

So in theory running a new build and updating the base images removes all known vulns for trivy.

- Builder image moved to go 1.21 as per go.mod
- Runtime image upgraded to alpine 3.19

Hopfully fixes kastenhq#218.

Signed-off-by: Peter Fiddes <[email protected]>
@hawksight hawksight marked this pull request as ready for review January 31, 2024 09:44
@julio-lopez julio-lopez requested a review from bathina2 February 1, 2024 07:22
@julio-lopez julio-lopez merged commit 6d642c2 into kastenhq:master Feb 1, 2024
4 checks passed
@julio-lopez
Copy link
Contributor

Thanks @hawksight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Address critical vulnerabilities
2 participants