Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that no arguments can be passed to commands that do not use any #112

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

mmotejlek
Copy link
Contributor

@mmotejlek mmotejlek commented Jul 18, 2022

Kubestr currently silently ignores unnecessary arguments that are passed to commands that do not use any. I have changed the behaviour to enforce that no arguments can be passed to these commands.

The reason is to prevent user errors that come from accidentally using unescaped space characters. In particular ( #105 ):
-N key=value, foo=bar
instead of
-N key=value,foo=bar
would be uncaught without this change.

@mmotejlek mmotejlek changed the title Enforce 0 arguments for commands that do not use any Enforce that no arguments can be passed to commands that do not use any Jul 18, 2022
@ihcsim
Copy link
Contributor

ihcsim commented Aug 10, 2022

Looks like the golangci-lint action failed because the setup-go action is trying to use go 1.19. Previous runs with go 1.18 worked. I will open another PR to pin the action to use go 1.18.

@ihcsim
Copy link
Contributor

ihcsim commented Aug 10, 2022

@mmotejlek can you rebase/merge your branch with master to get CI to pass? Thanks.

@mmotejlek
Copy link
Contributor Author

@ihcsim Done!

@ihcsim
Copy link
Contributor

ihcsim commented Aug 16, 2022

@pavannd1 @bathina2 PTAL and merge, when ready. Thanks.

@pavannd1 pavannd1 merged commit 3011d43 into kastenhq:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants