Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for sokol-gfx bindings cleanup. #31

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Conversation

floooh
Copy link
Collaborator

@floooh floooh commented Oct 21, 2024

DO NOT MERGE!

This PR contains the necessary updates for the upcoming sokol-gfx resource bindings update (which is a breaking change, thus this PR).

I'll take care of the merge when everything on the sokol side is done :)

For details see: floooh/sokol#1111

Reminder: after the sokol- and sokol-tools merge, and sokol-tools-bin having the latest binaries, also update build.zig.zon:

  • the sokol-tools-bin dep

@floooh floooh marked this pull request as ready for review November 7, 2024 15:57
@floooh
Copy link
Collaborator Author

floooh commented Nov 7, 2024

Hmm, btw, with a current Zig version I can't run the shaders task anymore, because the sokol-shdc binaries in the Zig cache don't have the execute file attribute set (this is on macOS).

Does that sound familiar somehow?

I'll need to merge the PR ahead of the sokol merge though (which I'll do within the next few hours).

E.g.:

sokol-d ➤ zig build shaders
shaders
└─ run /Users/floh/.cache/zig/p/12202522a9311ecc8ddcefd60b3943d1ca5a6717f5230a193ca63bf3d53c29c59bf7/bin/osx_arm64/sokol-shdc failure
error: unable to spawn /Users/floh/.cache/zig/p/12202522a9311ecc8ddcefd60b3943d1ca5a6717f5230a193ca63bf3d53c29c59bf7/bin/osx_arm64/sokol-shdc: AccessDenied

@floooh floooh merged commit a3d1281 into main Nov 7, 2024
3 checks passed
@floooh floooh deleted the issue1037_bindings_cleanup branch November 7, 2024 16:10
@kassane
Copy link
Owner

kassane commented Nov 7, 2024

@floooh ,

Does that sound familiar somehow?

Last time I saw this problem was emsdk_install. fixing by adding bash to the command, instead of chmod for posix.

What do you think about running the shdc (together bindgen) via CI/CD to update the shaders when there is a change?

@floooh
Copy link
Collaborator Author

floooh commented Nov 7, 2024

What do you think about running the shdc (together bindgen) via CI/CD to update the shaders when there is a change?

Not a fan :) We should find out whether not setting the exec flags is intended behaviour by the Zig package manager (I seem to recall some Zig issue or discussion about that - because this will also be a problem when Zig moves the Clang toolchain into a package).

Maybe we can somehow set the exec flags in build.zig as part of the shaders build job for now?

@kassane
Copy link
Owner

kassane commented Nov 7, 2024

Maybe we can somehow set the exec flags in build.zig as part of the shaders build job for now?

Could do.

@kassane kassane mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants