Move layout macros to kas-widgets; do not recurse internally #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are still used for custom widget layout (required to support references to the widget's fields). The main advantage of this change is simpler code analysis; rust-analyzer now correctly links methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout macros (
column!,grid!etc.) are moved into thekas::widgetsnamespace.These layout macros no longer recurse internally (except with feature
recursive-layout-widgets). This is slightly less optimal but means that e.g.column!["title", row!["a", "b"].map(|_| &())]is now possible since the internalrow![..]is a widget and thus supports all the usual methods. Caveat: this is incompatible with therecursive-layout-widgetsfeature, and thus we warn about it in all cases.Note that recursive layout macros must remain a feature to support usage in custom widgets where inner layout components may refer to fields of the custom widget, so all we're really doing is turning off this feature in the common case to improve diagnostic output.
Since these macros now behave (mostly) identically both within and outside of other layout macros, we can stop prepending with
kas::to identify non-recursive macro calls and just import the macros (explicitly, since glob import clashes with thestdcolumn!macro).