Update deps and enable winit/x11 by default #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that examples were failing on X11 with a confusing message. rust-windowing/winit#3414 fixes the message; this PR adds X11 to the default feature selection.
Update dependencies:
env_logger,cfg_aliases,resvgand most significantlywgpu.Safe handling of the window/surface lifetime. For now this uses
Arc<winit::window::Window>to ensure the window outlives the surface. A true (efficient) solution would be closer to the self-referential struct problem (though without the aliasing and pinning sub-problems); essentially we could "just" cast the lifetime to'static, however there's no good way to do this without makingnew_surfaceunsafe or depend on WGPU (havingwgpu::SurfaceTargetinraw-window-handlewould help).