Make AdaptEvents a thin wrapper over an inner widget #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes to handle_event::open_popup direct navigation to the correct widget Id but are not strictly necessary since next_nav_focus will traverse to find a navigable descendant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdaptEventsis now a special thin wrapper over the inner widget. Implications:IdAdaptEvents-wrapped widget would see a differentwidget_name(affecting debug output) but otherwise identical tree, assuming the wrapper did not use any message handlersEventCx::last_childfromAdaptEventsnow works as expected (instead of just returning the index of the wrapped child, 0)The latter is the main motivation, and makes it unnecessary to have message handler support in
GridandList(which could be confusing in practice without also supporting.on_configureand.on_updateon those types).This exposed a couple of potential issues in
ComboBoxwhich were fixed.Also: add
fn EventCx::try_debugto support debugging of unexpected message types in message handlers.