Rename timer_update → timer, add AdaptEventCx, pass only ConfigCx to Widget::_nav_next #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of fixes and tweaks used while updating 7GUIs.
first
ofEventState::request_timer_update
since it is reasonable to always usetrue
timer_update
→timer
for brevityAdaptConfigCx
andAdaptEventCx
. These are essentiallyConfigCx
/EventCx
plus anId
, allowing some methods to be called without specifying anid
(for use from methods likeAdapt::on_configure
). This is very much a half-baked addition; likely more methods should be supported, possibly these should be moved tokas-core
, possibly even integrated withConfigCx
andEventCx
(the latter is not ideal since various methods such as_send
impls would need to update theid
both before and after recursing to children).MatrixData::ColKey: DataKey
andRowKey: DataKey
bound (not needed)ConfigCx
(instead ofEventCx
) intoWidget::_nav_next
. This fixes a slightly obscure bug whereListView::_nav_next
would setEventCx::scroll
, nothing would handle or clear this, and later adebug_assert!
onEventCx::send_event
would fail.ListView::_nav_next
andMatrixView::_nav_next
Lost
)KeyFocus
with mouse input