Updates to release v1.3.9 fixes #288

kartik-v · Dec 18, 2018 · ad58747 · ad58747
1 parent 99f8892
commit ad58747
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 13 deletions.
diff --git a/CHANGE.md b/CHANGE.md
@@ -1,6 +1,12 @@
 Change Log: `yii2-export`
 =========================
 
+## version 1.3.9
+
+**Date:** _under development_
+
+- (enh #288): Correct export column selection when `asDropdown` is `false`.
+
 ## version 1.3.8
 
 **Date:** 29-Nov-2018

diff --git a/src/ExportColumnAsset.php b/src/ExportColumnAsset.php
@@ -3,7 +3,7 @@
 /**
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
  * @package yii2-export
- * @version 1.3.8
+ * @version 1.3.9
  */
 
 namespace kartik\export;

diff --git a/src/ExportMenu.php b/src/ExportMenu.php
@@ -4,7 +4,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  */
 
 namespace kartik\export;
@@ -166,6 +166,7 @@ class ExportMenu extends GridView
 
     /**
      * @var boolean whether to show a column selector to select columns for export. Defaults to `true`.
+     * This is applicable only if [[asDropdown]] is set to `true`. Else this property is ignored.
      */
     public $showColumnSelector = true;
 
@@ -845,7 +846,7 @@ protected function initSettings()
         if (!isset($this->afterSaveView)) {
             $this->afterSaveView = "{$path}/_view";
         }
-        $this->_columnSelectorEnabled = $this->showColumnSelector;
+        $this->_columnSelectorEnabled = $this->showColumnSelector && $this->asDropdown;
         $request = Yii::$app->request;
         $this->_triggerDownload = $request->post($this->exportRequestParam, $this->triggerDownload);
         $this->_exportType = $request->post($this->exportTypeParam, $this->exportType);

diff --git a/src/ExportMenuAsset.php b/src/ExportMenuAsset.php
@@ -3,7 +3,7 @@
 /**
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
  * @package yii2-export
- * @version 1.3.8
+ * @version 1.3.9
  */
 
 namespace kartik\export;

diff --git a/src/ExportWriterPdf.php b/src/ExportWriterPdf.php
@@ -3,7 +3,7 @@
 /**
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
  * @package yii2-export
- * @version 1.3.8
+ * @version 1.3.9
  */
 
 namespace kartik\export;

diff --git a/src/assets/css/kv-export-columns.css b/src/assets/css/kv-export-columns.css
@@ -2,7 +2,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Columns Selector Style Sheet
  *

diff --git a/src/assets/css/kv-export-columns.min.css b/src/assets/css/kv-export-columns.min.css
@@ -2,7 +2,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Columns Selector Style Sheet
  *

diff --git a/src/assets/js/kv-export-columns.js b/src/assets/js/kv-export-columns.js
@@ -2,7 +2,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Columns Selector Validation Module.
  *

diff --git a/src/assets/js/kv-export-columns.min.js b/src/assets/js/kv-export-columns.min.js
@@ -2,7 +2,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Columns Selector Validation Module.
  *

diff --git a/src/assets/js/kv-export-data.js b/src/assets/js/kv-export-data.js
@@ -2,7 +2,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Data Validation Module.
  *

diff --git a/src/assets/js/kv-export-data.min.js b/src/assets/js/kv-export-data.min.js
diff --git a/src/views/_columns.php b/src/views/_columns.php
@@ -3,7 +3,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  * 
  * Column Selector View
  *

diff --git a/src/views/_view.php b/src/views/_view.php
@@ -3,7 +3,7 @@
  * @package   yii2-export
  * @author    Kartik Visweswaran <[email protected]>
  * @copyright Copyright &copy; Kartik Visweswaran, Krajee.com, 2015 - 2018
- * @version   1.3.8
+ * @version   1.3.9
  *
  * Export Submission View
  *