Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wombag-search: Add w-search-open-in-wallabag #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EFLS
Copy link

@EFLS EFLS commented Nov 1, 2024

I'm really liking Wombag as a Wallabag interface, especially because it feels so much like elfeed. I really love how you've made the live search so easy to use because of the help buffer.

While playing around with Wombag, I came up with the following function that might be useful to other users as well. I like to highlight passages as I read them, so I often visit articles in the web-interface. This pull request provides a function and a key for that.

Original commit comment: New function in wombag-search to open entry at point in the Wallabag web interface, using wombag-browse-url-function.

New function in wombag-search to open entry at point in the Wallabag
web interface, using wombag-browse-url-function.
@karthink
Copy link
Owner

karthink commented Nov 8, 2024

I'm really liking Wombag as a Wallabag interface, especially because it feels so much like elfeed. I really love how you've made the live search so easy to use because of the help buffer.

Thanks! But the credit for the interface design goes to @skeeto (for Elfeed, obviously) and @chenyanming (who wrote wallabag.el).

New function in wombag-search to open entry at point in the Wallabag web interface, using wombag-browse-url-function.

This is useful, could you also bind this in wombag-show-mode-map?

Add a function to open the currently shown Wombag article in the
Wallabag web interface, similar to w-search-open-in-wallabag.
@EFLS
Copy link
Author

EFLS commented Nov 10, 2024

This is useful, could you also bind this in wombag-show-mode-map?

Good idea! See the new commit. My Elisp skills are limited, but I think I managed by copying your code, more or less.

@skeeto
Copy link

skeeto commented Nov 10, 2024

@karthink, I didn't know about this, thanks! Glad to see more interfaces like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants