-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedex tracker updates and dashboard Tracker updates #702
base: main
Are you sure you want to change the base?
Fedex tracker updates and dashboard Tracker updates #702
Conversation
ChrisNolan
commented
Oct 2, 2024
•
edited
Loading
edited
- Fedex 'signed_by' now 'falls back' to 'receivedByName' if 'signedByName' is missing
- Tracker dashboard will display the signed_by if the status is Delivered
- Refactor the 'Tracking-preview' and 'Tracking-page' to be more DRY and reuse components (worried about my 'typescript' skills here) and add the 'additional info' to the header
- Fedex's SPOD - Signature Proof of Delivery has been refactored from the 'util' to the 'proxy' and correctly authenticates now, so that the PNG is now stored on the 'tracking-status' table (but still need help figuring out how to display/access it via the dashboard)
…n tracking the 'signed_by' info
…ook-co/karrio into fedex_tracker_updates
…ttempt to make a '404' page to resolve next warnings... no luck
…selves and re-use new components
…t it works now at least
…n tracking the 'signed_by' info
…selves and re-use new components
…ook-co/karrio into fedex_tracker_updates
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core? |
Hi @ChrisNolan, Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. |
Ah, that explains it. Originally I had a question about how to get the signature images to display and you asked to see the code so you had a better sense of what I meant. That was the code that wasn't 'ready'. I posted that and got no comments. Then I rebased and more or less 'finished' it and re-made the PR-- still wanting to know how to access the signature images but at least the data was going to be captured in the mean time. I was also curious about if the move I had made of the logic to signin to get the signature images was put in the right spot (the authentication was failing otherwise). And the 'tiny' change to 'signed by' to fallback to 'received by' if it was missing is in here too which is much more of a 'bug fix' than any improvement, so that could potentially be moved out into a 'issue' perhaps. I'll have to look into this 'Insiders' program more closely. |