Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedex tracker updates and dashboard Tracker updates #702

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

ChrisNolan
Copy link
Contributor

@ChrisNolan ChrisNolan commented Oct 2, 2024

  • Fedex 'signed_by' now 'falls back' to 'receivedByName' if 'signedByName' is missing
  • Tracker dashboard will display the signed_by if the status is Delivered image
  • Refactor the 'Tracking-preview' and 'Tracking-page' to be more DRY and reuse components (worried about my 'typescript' skills here) and add the 'additional info' to the header
    image
  • Fedex's SPOD - Signature Proof of Delivery has been refactored from the 'util' to the 'proxy' and correctly authenticates now, so that the PNG is now stored on the 'tracking-status' table (but still need help figuring out how to display/access it via the dashboard)

…ttempt to make a '404' page to resolve next warnings... no luck
Copy link

coderabbitai bot commented Oct 2, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ChrisNolan
Copy link
Contributor Author

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

@danh91
Copy link
Member

danh91 commented Nov 21, 2024

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

Hi @ChrisNolan,
I thought you said somewhere that it was still a draft and you would let me know when the PR is ready.
Haven't looked into your changes since then.

Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable.
And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.

@ChrisNolan
Copy link
Contributor Author

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

Hi @ChrisNolan, I thought you said somewhere that it was still a draft and you would let me know when the PR is ready. Haven't looked into your changes since then.

Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.

Ah, that explains it. Originally I had a question about how to get the signature images to display and you asked to see the code so you had a better sense of what I meant. That was the code that wasn't 'ready'. I posted that and got no comments. Then I rebased and more or less 'finished' it and re-made the PR-- still wanting to know how to access the signature images but at least the data was going to be captured in the mean time. I was also curious about if the move I had made of the logic to signin to get the signature images was put in the right spot (the authentication was failing otherwise).

And the 'tiny' change to 'signed by' to fallback to 'received by' if it was missing is in here too which is much more of a 'bug fix' than any improvement, so that could potentially be moved out into a 'issue' perhaps.

I'll have to look into this 'Insiders' program more closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants