feat(dependenciesdistributor): remove log #6072
Conversation
karmada-bot
added
the
size/XS
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6072 +/- ##
==========================================
- Coverage 48.33% 48.32% -0.02%
==========================================
Files 666 666
Lines 54858 54857 -1
==========================================
- Hits 26518 26511 -7
- Misses 26616 26621 +5
- Partials 1724 1725 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -186,7 +186,7 @@ func (d *DependenciesDistributor) reconcileResourceTemplate(key util.QueueKey) e | |||
|
|
|||
| matched := matchesWithBindingDependencies(resourceTemplateKey, binding) | |||
| if !matched { | |||
| klog.V(4).Infof("No need to sync binding(%s/%s)", binding.Namespace, binding.Name) | |||
| klog.V(5).Infof("No need to sync binding(%s/%s)", binding.Namespace, binding.Name) | |||
There was a problem hiding this comment.
The logic here is more like selecting a small number of items from a large set, logging for items that do not match isn't really helpful, right?
In other words, shall we remove this log?
There was a problem hiding this comment.
Sounds good. We already have the matching logs, so the rest is negligible unmatched resources.
There was a problem hiding this comment.
I agree to remove this log
CharlesQQ
force-pushed
the
set-log-level-new
branch
from
7abe29a to
d7a8732
Compare
CharlesQQ
changed the title
CharlesQQ
changed the title
|
Hi @CharlesQQ CI is failing |
Signed-off-by: chang.qiangqiang <[email protected]>
CharlesQQ
force-pushed
the
set-log-level-new
branch
from
d7a8732 to
a115a22
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
What this PR does / why we need it:
fix controller print too many "No need to sync binding" log when restarts
Which issue(s) this PR fixes:
Fixes #6071
Special notes for your reviewer:
Does this PR introduce a user-facing change?: