-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the attached binding deletion problem #6034
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6034 +/- ##
==========================================
- Coverage 48.37% 48.37% -0.01%
==========================================
Files 665 666 +1
Lines 54831 54835 +4
==========================================
Hits 26524 26524
- Misses 26590 26593 +3
- Partials 1717 1718 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks, @whitewindmills let me take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr is similar to this logic processing scenario. Can we refer to this scenario:
karmada/pkg/detector/detector.go
Lines 459 to 464 in 8313813
// If this binding exists and its owner is not the input object, return error and let garbage collector | |
// delete this binding and try again later. See https://github.com/karmada-io/karmada/issues/2090. | |
if ownerRef := metav1.GetControllerOfNoCopy(bindingCopy); ownerRef != nil && ownerRef.UID != object.GetUID() { | |
return fmt.Errorf("failed to update binding due to different owner reference UID, will " + | |
"try again later after binding is garbage collected, see https://github.com/karmada-io/karmada/issues/2090") | |
} |
6acb412
to
8699d21
Compare
@XiShanYongYe-Chang PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
Signed-off-by: whitewindmills <[email protected]>
8699d21
to
b10c102
Compare
@XiShanYongYe-Chang PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
Do you think we need to cherry-pick this patch to the previous branch?
/cc @RainbowMango
yes, it's necessary. |
kindly ping @RainbowMango |
Can you help add a release note? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I added a release note to this PR. |
@RainbowMango @XiShanYongYe-Chang |
All maintains branches, release-1.12, release-1.11, and release-1.10. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
I created a deployment that used a PVC as it's dependent resource, and the PVC was able to follow the deployment propagation correctly. When I deleted the PVC and recreated it, I found that the PVC did not follow the deployment propagation because it's ResourceBinding was not created.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?: