-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Profile Choice Functionality To The Module #47
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -95,7 +96,7 @@ var FirefoxBrowser = function(id, baseBrowserDecorator, args, logger) { | |||
fs.writeFileSync(profilePath + '/prefs.js', this._getPrefs(args.prefs)); | |||
self._execCommand( | |||
command, | |||
[url, '-profile', profilePath, '-no-remote'].concat(flags) | |||
[url, (customProfile !== '') ? '-p ' + customProfile : '-profile ' + profilePath , '-no-remote'].concat(flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's break this up into multiple lines please
Can you add some documentation on how to use this to the Readme as well please? |
Sure, I just pushed it. |
customLaunchers: { | ||
FirefoxWithMyExtension: { | ||
base: 'Firefox', | ||
customProfile: 'Karma', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use 2 spaces indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
+1 |
|
||
customLaunchers: { | ||
FirefoxWithMyExtension: { | ||
base: 'Firefox', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use consistent indentation of two spaces
@barakhaim one style issue and after that please squash all commits into one ( |
For what it's worth, I rebased this over on the |
Too old, closing, feel free to reopen is still relevant! |
Added the option to mimic "firefox.exe -p ".
When adding "customProfile" to the "customLauncher" firefox will launch said profile. The profiles list is shown when you execute "firefox.exe -p". This was added as a solution to karma-runner/karma-firefox-launcher issue #46 .
Example:
browsers: ['FirefoxWithMyExtension'],
customLaunchers: {
FirefoxWithMyExtension: {
base: 'Firefox',
customProfile: 'Karma',
extensions: [
path.resolve(__dirname, '../[email protected]'),
]
}}
This will upload the "karma" firefox i've setup beforehand using "firefox.exe -p", in it, my configs, such as imported certs.
Ignoring this field will save the exact API of the original.