fix: change RBAC subject to serviceAccountName helper #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 11.21% 11.21%
=======================================
Files 2 2
Lines 107 107
=======================================
Hits 12 12
Misses 93 93
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@henryjarend thanks for PR, please amend your git message. we need semantic commit message for new helm chart release. |
henryjarend
changed the title
added 2 commits
December 8, 2023 13:44
|
done! |
|
🎉 This PR is included in version 1.2.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix the subject Name in the RoleBinding definition so that when a custom service account name is used that will be reflected in the rolebinding as well.
This is in regards to issue 89