chore(helm): fix deployment configuration

karlderkaefer · Nov 18, 2022 · 9a25b34 · 9a25b34
1 parent 59f3cb0
commit 9a25b34
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/charts/argocd-ecr-updater/Chart.yaml b/charts/argocd-ecr-updater/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: argocd-ecr-updater
 description: A Helm chart to update the ECR token for ECR based helm repositories
 type: application
-version: 0.3.2
+version: 0.3.3
 appVersion: "1.1.6"
 sources:
   - https://github.com/karlderkaefer/argocd-ecr-update

diff --git a/charts/argocd-ecr-updater/README.md b/charts/argocd-ecr-updater/README.md
@@ -2,7 +2,7 @@
 
 A Helm chart to update the ECR token for ECR based helm repositories
 
-![Version: 0.3.2](https://img.shields.io/badge/Version-0.3.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.1.6](https://img.shields.io/badge/AppVersion-1.1.6-informational?style=flat-square)
+![Version: 0.3.3](https://img.shields.io/badge/Version-0.3.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.1.6](https://img.shields.io/badge/AppVersion-1.1.6-informational?style=flat-square)
 
 ## Maintainers
 

diff --git a/charts/argocd-ecr-updater/templates/configmap.yaml b/charts/argocd-ecr-updater/templates/configmap.yaml
@@ -5,7 +5,7 @@ metadata:
   labels:
     {{- include "argocd-ecr-updater.labels" . | nindent 4 }}
 data:
-  ARGOCD_ECR_UPDATER_NAMESPACE: {{ .Values.env.namespace }}
+  ARGOCD_ECR_UPDATER_NAMESPACE: {{ .Values.env.namespace | quote }}
   {{- range $key, $val := .Values.env.additionalEnv }}
-  {{ $key }}: {{ $val }}
+  {{ $key }}: {{ $val | quote }}
   {{- end }}
diff --git a/charts/argocd-ecr-updater/templates/deployment.yaml b/charts/argocd-ecr-updater/templates/deployment.yaml
@@ -35,10 +35,9 @@ spec:
             {{- toYaml .Values.containerSecurityContext | nindent 12 }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
-          env:
-            - valueFrom:
-                configMapKeyRef:
-                  key: {{ include "argocd-ecr-updater.fullname" . }}
+          envFrom:
+            - configMapRef:
+                name: {{ include "argocd-ecr-updater.fullname" . }}
           ports:
             - name: http
               containerPort: 8080