2.4.0 release

.github/workflows/build-source.yml

@@ -34,30 +34,16 @@ jobs:
       - name: Restore client
         run: npm ci
         working-directory: source/client
-      - name: Audit client
-        run: npm audit --omit=dev
-        working-directory: source/client
       - name: Build client
         run: npm run build
         working-directory: source/client
-      - name: Test client
-        run: npm run test:ci
-        working-directory: source/client
       - name: Setup .NET Core
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 8.x
       - name: Restore server
         run: dotnet restore
         working-directory: source/server
-      - name: Test server
-        shell: pwsh
-        run: |
-          dotnet test `
-            Karamem0.Teamtile.Tests/Karamem0.Teamtile.Tests.csproj `
-            -p:AltCover=true `
-            -- NUnit.TestOutputXml=${{github.workspace}}/source/server/test
-        working-directory: source/server
       - name: Build server
         shell: pwsh
         run: |
@@ -73,18 +59,3 @@ jobs:
         with:
           name: build
           path: source/server/build
-      - name: Upload test results
-        uses: enricomi/publish-unit-test-result-action/linux@v2
-        if: always()
-        with:
-          files: |
-            source/client/test/**/*.xml
-            source/server/test/**/*.xml
-          check_name: Test results
-      - name: Upload coverage reports
-        uses: codecov/codecov-action@v4
-        if: always()
-        with:
-          fail_ci_if_error: true
-          token: ${{secrets.CODECOV_TOKEN}}
-          slug: karamem0/teamtile

.github/workflows/develop.yml

@@ -4,8 +4,15 @@ on:
       - develop
 
 jobs:
+  test:
+    name: Test source
+    uses: ./.github/workflows/test.yml
+    secrets: inherit
+    with:
+      environment: dev
   build-source:
     name: Build source
+    needs: test
     uses: ./.github/workflows/build-source.yml
     secrets: inherit
     with:

.github/workflows/test.yml

@@ -0,0 +1,53 @@
+on:
+  workflow_call:
+    inputs:
+      environment:
+        required: true
+        type: string
+
+jobs:
+  run:
+    name: Run
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repos
+        uses: actions/checkout@v4
+      - name: Setup Node.js 20.x
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20.x
+      - name: Restore client
+        run: npm ci
+        working-directory: source/client
+      - name: Audit client
+        run: npm audit --omit=dev
+        working-directory: source/client
+      - name: Test client
+        run: npm run test:ci
+        working-directory: source/client
+      - name: Restore server
+        run: dotnet restore
+        working-directory: source/server
+      - name: Test server
+        shell: pwsh
+        run: |
+          dotnet test `
+            Karamem0.Teamtile.Tests/Karamem0.Teamtile.Tests.csproj `
+            -p:AltCover=true `
+            -- NUnit.TestOutputXml=${{github.workspace}}/source/server/test
+        working-directory: source/server
+      - name: Upload test results
+        uses: enricomi/publish-unit-test-result-action/linux@v2
+        if: always()
+        with:
+          files: |
+            source/client/test/**/*.xml
+            source/server/test/**/*.xml
+          check_name: Test results
+      - name: Upload coverage reports
+        uses: codecov/codecov-action@v4
+        if: always()
+        with:
+          fail_ci_if_error: true
+          token: ${{secrets.CODECOV_TOKEN}}
+          slug: karamem0/teamtile

source/client/eslint.config.mjs

@@ -13,6 +13,7 @@ import globals from 'globals';
 import js from '@eslint/js';
 import path from 'path';
 import pluginHooks from 'eslint-plugin-hooks';
+import pluginSonarjs from 'eslint-plugin-sonarjs';
 import pluginTestingLibrary from 'eslint-plugin-testing-library';
 
 const compat = new FlatCompat({
@@ -30,7 +31,8 @@ export default [
       }
     },
     'plugins': {
-      'hooks': pluginHooks
+      'hooks': pluginHooks,
+      'sonarjs': pluginSonarjs
     },
     'settings': {
       'react': {
@@ -43,8 +45,7 @@ export default [
     'plugin:@typescript-eslint/recommended',
     'plugin:jsx-a11y/recommended',
     'plugin:react/recommended',
-    'plugin:react-hooks/recommended',
-    'plugin:sonarjs/recommended-legacy'
+    'plugin:react-hooks/recommended'
   )),
   {
     'files': [
@@ -124,7 +125,7 @@ export default [
       ],
       '@stylistic/indent-binary-ops': [
         'error',
-        4
+        2
       ],
       '@stylistic/jsx-closing-bracket-location': [
         'error',

source/client/jest.setup.mjs

@@ -7,9 +7,12 @@
 //
 
 import 'jest-localstorage-mock';
+import { TextDecoder } from 'util';
 import fetchMock from 'jest-fetch-mock';
 
 // Mock fetch
 fetchMock.enableMocks();
 // Mock env
 jest.mock('./src/env', () => ({}));
+// Text decoder
+globalThis.TextDecoder = TextDecoder;