Skip to content

Commit

Permalink
Fix cache time and remove invalid source maps references (#153)
Browse files Browse the repository at this point in the history
* align roda routing styling

* same for pro

* improve caching

* typo
  • Loading branch information
mensfeld authored Sep 24, 2023
1 parent 7bdd376 commit d7a081a
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Karafka Web changelog

## 0.7.5 (Unreleased)
- [Fix] Cache assets for 1 year instead of 7 days.
- [Fix] Remove source maps pointing to non-existing locations.
- [Maintenance] Include license and copyrights notice for `timeago.js` that was missing in the JS min file.

## 0.7.4 (2023-09-19)
Expand Down
2 changes: 1 addition & 1 deletion lib/karafka/web/ui/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Base < Roda
root: Karafka::Web.gem_root.join('lib/karafka/web/ui/public'),
# Cache all static files for the end user for as long as possible
# We can do it because we ship per version assets so they invalidate with gem bumps
headers: { 'Cache-Control' => 'max-age=604800' }
headers: { 'Cache-Control' => 'max-age=31536000, immutable' }
)
plugin :render_each
plugin :partials
Expand Down
1 change: 0 additions & 1 deletion lib/karafka/web/ui/public/javascripts/bootstrap.min.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion lib/karafka/web/ui/public/javascripts/chart.min.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion lib/karafka/web/ui/public/stylesheets/bootstrap.min.css

Large diffs are not rendered by default.

This file was deleted.

2 changes: 1 addition & 1 deletion lib/karafka/web/ui/views/shared/_header.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<link href="<%= asset_path('stylesheets/datepicker.min.css') %>" rel="stylesheet">
<link href="<%= asset_path('stylesheets/application.css') %>" rel="stylesheet">

<script type="module" src="<%= asset_path('javascripts/chart.min.js') %>"></script>
<script type="text/javascript" src="<%= asset_path('javascripts/chart.min.js') %>"></script>
<script type="text/javascript" src="<%= asset_path('javascripts/timeago.min.js') %>"></script>
<script type="text/javascript" src="<%= asset_path('javascripts/bootstrap.min.js') %>"></script>
<script type="text/javascript" src="<%= asset_path('javascripts/highlight.min.js') %>"></script>
Expand Down

0 comments on commit d7a081a

Please sign in to comment.