Convert output value to bool #180

Set initial GPIO output valued based on invertonoffGPIOPin #180
kantlivelong · Apr 16, 2021 · 8418af5 · 8418af5
1 parent 025a7fa
commit 8418af5
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/octoprint_psucontrol/__init__.py b/octoprint_psucontrol/__init__.py
@@ -162,13 +162,16 @@ def configure_gpio(self):
             self._logger.info("Using GPIO for On/Off")
             self._logger.info("Configuring GPIO for pin {}".format(self.config['onoffGPIOPin']))
 
+            if not self.config['invertonoffGPIOPin']:
+                initial_output = 'low'
+            else:
+                initial_output = 'high'
+
             try:
-                pin = periphery.GPIO(self.config['GPIODevice'], self.config['onoffGPIOPin'], 'out')
+                pin = periphery.GPIO(self.config['GPIODevice'], self.config['onoffGPIOPin'], initial_output)
                 self._configuredGPIOPins['switch'] = pin
             except Exception as e:
                 self._logger.error(e)
-            else:
-                pin.write(not self.config['invertonoffGPIOPin'])
 
         if self.config['sensingMethod'] == 'GPIO':
             self._logger.info("Using GPIO sensing to determine PSU on/off state.")
@@ -455,7 +458,7 @@ def turn_psu_on(self):
                 self._logger.debug("On system command returned: {}".format(r))
             elif self.config['switchingMethod'] == 'GPIO':
                 self._logger.debug("Switching PSU On Using GPIO: {}".format(self.config['onoffGPIOPin']))
-                pin_output = 1 ^ self.config['invertonoffGPIOPin']
+                pin_output = bool(1 ^ self.config['invertonoffGPIOPin'])
 
                 try:
                     self._configuredGPIOPins['switch'].write(pin_output)
@@ -512,7 +515,7 @@ def turn_psu_off(self):
                 self._logger.debug("Off system command returned: {}".format(r))
             elif self.config['switchingMethod'] == 'GPIO':
                 self._logger.debug("Switching PSU Off Using GPIO: {}".format(self.config['onoffGPIOPin']))
-                pin_output = 0 ^ self.config['invertonoffGPIOPin']
+                pin_output = bool(0 ^ self.config['invertonoffGPIOPin'])
 
                 try:
                     self._configuredGPIOPins['switch'].write(pin_output)