fix: empty link bug

kannon-email · Jun 24, 2024 · e122ea7 · e122ea7
1 parent 1ac1425
commit e122ea7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/internal/mailbuilder/mailbuilder.go b/internal/mailbuilder/mailbuilder.go
@@ -186,7 +186,7 @@ func insertTrackLinkInHTML(html string, link string) string {
 	return strings.Replace(html, "</body>", fmt.Sprintf(`<img src="%s" style="display:none;"/></body>`, link), 1)
 }
 
-var regLink = regexp.MustCompile(`<a\s+(?:[^>]*?\s+)?href=["'](.*?)["']`)
+var regLink = regexp.MustCompile(`<a\s+(?:[^>]*?\s+)?href=["'](.+?)["']`)
 
 func replaceLinks(html string, replace func(link string) (string, error)) (string, error) {
 	matches := regLink.FindAllStringSubmatch(html, -1)

diff --git a/internal/mailbuilder/message_test.go b/internal/mailbuilder/message_test.go
@@ -82,6 +82,22 @@ func TestInsertTrackLink(t *testing.T) {
 	assert.Equal(t, expectedhtml, res)
 }
 
+func TestEmptyAHrefLink(t *testing.T) {
+	html := `<html>
+<body>
+<a href="" />
+</body></html>`
+
+	expectedhtml := html
+
+	res, err := replaceLinks(html, func(link string) (string, error) {
+		return link + "x", nil
+	})
+
+	assert.Nil(t, err)
+	assert.Equal(t, expectedhtml, res)
+}
+
 func TestReplaceCustomFields(t *testing.T) {
 	str := "Hello {{name}}"
 	fields := map[string]string{