Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value of PodReadyWaitTimeoutEnv #3310

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Jan 3, 2025

Change Overview

Update value of PodReadyWaitTimeoutEnv from KANISTER_POD_READY_WAIT_TIMEOUT to TIMEOUT_WORKER_POD_READY

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

…IMEOUT to TIMEOUT_WORKER_POD_READY

Signed-off-by: Rajat Gupta <[email protected]>
@pavannd1
Copy link
Contributor

pavannd1 commented Jan 3, 2025

@r4rajat could we add some unit tests for this if we don't already have anything?

@r4rajat
Copy link
Contributor Author

r4rajat commented Jan 6, 2025

@r4rajat could we add some unit tests for this if we don't already have anything?

@pavannd1 we already have Unit Tests for same

@r4rajat r4rajat added the kueue label Jan 6, 2025
@mergify mergify bot merged commit 276f676 into master Jan 6, 2025
25 checks passed
@mergify mergify bot deleted the update-pod-ready-wait-timeout-const branch January 6, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants