Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Snapshot alpha and beta APIs #3309

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Jan 3, 2025

Change Overview

Since VolumeSnapshot API version has already moved to v1 and set it as default (https://kubernetes.io/blog/2020/12/10/kubernetes-1.20-volume-snapshot-moves-to-ga/), the support for alpha and beta APIs becomes redundant. This PR removes support for VolumeSnapshot alpha and beta APIs

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Prasad Ghangal <[email protected]>
@PrasadG193 PrasadG193 force-pushed the remove-snapshot-apis branch from e5a29a6 to 6bb546b Compare January 3, 2025 10:07
Signed-off-by: Prasad Ghangal <[email protected]>
@viveksinghggits
Copy link
Contributor

Even if the resources are moved to v1 would people still be able to create these resources in any other version? and would that be problem for us in any way, if we merge this PR?

@PrasadG193
Copy link
Contributor Author

@viveksinghggits after k8s 1.20, even if we try to create Snapshot with other APIs, it will be defaulted to v1 with conversion webhook. We had already done this experiment during #1979 (comment). So its guaranteed that there will be only v1 APIs present on latest clusters.

Copy link
Contributor

mergify bot commented Jan 6, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 0abc731 into master Jan 6, 2025
25 checks passed
@mergify mergify bot deleted the remove-snapshot-apis branch January 6, 2025 18:08
aaron-kasten pushed a commit to aaron-kasten/kanister that referenced this pull request Jan 13, 2025
Signed-off-by: Prasad Ghangal <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Aaron Alpar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants