Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Rework extra blueprints to separate DB tools image and kanister-tools image #3287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Rework extra blueprints to separate DB tools image and kanister-tools image #3287

wants to merge 1 commit into from

Conversation

hairyhum
Copy link
Contributor

Change Overview

Follow up to #3284

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@hairyhum hairyhum mentioned this pull request Dec 10, 2024
Closed
11 tasks
@hairyhum hairyhum force-pushed the blueprints-rework-extra branch from e1465a6 to 08a2dd2 Compare December 13, 2024 20:42
@hairyhum
Copy link
Contributor Author

hairyhum commented Jan 16, 2025 •
edited
Loading

Blocked by #3330

@hairyhum hairyhum changed the title docs: Rework blueprints to separate DB tools image and kanister-tools image docs: Rework extra blueprints to separate DB tools image and kanister-tools image Jan 16, 2025
@hairyhum hairyhum force-pushed the blueprints-rework-extra branch from 4f04191 to 765dee2 Compare January 16, 2025 20:22
@hairyhum hairyhum marked this pull request as ready for review January 16, 2025 20:22
@viveksinghggits
Copy link
Contributor

@hairyhum ,
should we update ALL the blueprints? Or should we just add a new example with the blueprint that uses the newly introduced kanister functions.
I am suggesting this because if this change doesn't significantly change the way users create/work on blueprints, and we change blueprints in the examples, users might get confused if they look into the new blueprints.
what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhum @viveksinghggits