fix: set default namespace and serviceaccount for MultiContainerRun pods #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubeTask is setting defaults in kube.GetPodObjectFromPodOptions Since MultiContainerRun uses k8s api directly to create pods, the defaults need to be set explicitly. Signed-off-by: Daniil Fedotov <[email protected]>
11 tasks
11 tasks
Signed-off-by: Daniil Fedotov <[email protected]>
pavannd1
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Set default namespace and serviceaccount when creating podSpec.
This was missed when initially implementing MultiContainerRun.
KubeTask is setting defaults in kube.GetPodObjectFromPodOptions Since MultiContainerRun uses k8s api directly to create pods, the defaults need to be set explicitly.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan