Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comments and variable names #3262

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/blockstorage/azure/azuredisk.go
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,12 @@ func (s *AdStorage) SnapshotsList(ctx context.Context, tags map[string]string) (
return nil, errkit.Wrap(err, "SnapshotsClient.List in SnapshotsList")
}
for _, snap := range page.Value {
k10Snap, err := s.SnapshotParse(ctx, *snap)
parsedSnap, err := s.SnapshotParse(ctx, *snap)
if err != nil {
log.WithError(err).Print("Incorrect Snaphost type", field.M{"SnapshotID": snap.ID})
continue
}
snaps = append(snaps, k10Snap)
snaps = append(snaps, parsedSnap)
}
}
snaps = blockstorage.FilterSnapshotsWithTags(snaps, blockstorage.SanitizeTags(tags))
Expand Down
2 changes: 1 addition & 1 deletion pkg/blockstorage/tags/tags.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
const (
// ClusterTagKey is used to tag resources with the cluster name
ClusterTagKey = "kanister.io/clustername"
// VersionTagKey is used to tag resources with the K10 version
// VersionTagKey is used to tag resources with a version
VersionTagKey = "kanister.io/version"
// AppNameTag is used to tag volumes with the app they belong to
AppNameTag = "kanister.io/appname"
Expand Down
2 changes: 1 addition & 1 deletion pkg/objectstore/directory.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func (d *directory) Put(ctx context.Context, name string, r io.Reader, size int6
if d.path == "" {
return errors.New("invalid entry")
}
// K10 tags include '/'. Remove them, at least for S3
// Replace any '/' in tags with '-'.
sTags := sanitizeTags(tags)

objName := d.absPathName(name)
Expand Down