fix: Quote profile json when passing to kando in go code #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhum
force-pushed
the
unsafe-quoting
branch
from
8617589 to
2ad733d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
viveksinghggits
approved these changes
Nov 28, 2024
| @@ -106,7 +128,7 @@ func (s *RDSFunctionsTest) TestPrepareCommand(c *check.C) { | |||
| for db in "${dblist[@]}"; | |||
| do echo "backing up $db db" && pg_dump $db -C --inserts > /backup/$db.sql; | |||
| done | |||
| tar -zc backup | kando location push --profile '%s' --path "${BACKUP_PREFIX}/${BACKUP_ID}" - | |||
| tar -zc backup | kando location push --profile "%s" --path "${BACKUP_PREFIX}/${BACKUP_ID}" - | |||
There was a problem hiding this comment.
I see that at some places we are providing profile in double quotes "" and at some place without. Is that intentional?
There was a problem hiding this comment.
In some tests we just pass "null" string to this function. We can make it more consistent by passing "\"null\"" instead, I guess.
There was a problem hiding this comment.
I am good, even if you want to merge this with current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add quoting when building kando command with profile in go code.
Add unit test case for non-null profile.
Fixes https://github.com/kanisterio/kanister/security/code-scanning/198 and https://github.com/kanisterio/kanister/security/code-scanning/199
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan