chore: Errkit migration 8.3 - migrate remaining piece of pkg/kube to errkit
#3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugen Sumin <[email protected]>
e-sumin
force-pushed
the
errkit_migration_8_3_kube
branch
from
2667451 to
0a4cbd6
Compare
e-sumin
changed the title
pkg/kube to errkitpkg/kube to errkit
pkg/kube/pod_test.go
Outdated
| @@ -1244,3 +1245,18 @@ func (s *PodSuite) TestAddAnnotations(c *check.C) { | |||
| c.Assert(tc.podOptions, check.DeepEquals, tc.expectedPodOptions) | |||
| } | |||
| } | |||
|
|
|||
| func (s *PodSuite) TestSomething(c *check.C) { | |||
There was a problem hiding this comment.
I think we should either rename this method or try to add comment that explains what exactly we are planning to test in this.
There was a problem hiding this comment.
great catch, thank you !
I've renamed it and made it working as I wanted originally.
viveksinghggits
approved these changes
Nov 28, 2024
Signed-off-by: Eugen Sumin <[email protected]>
e-sumin
force-pushed
the
errkit_migration_8_3_kube
branch
from
98016e4 to
672e66d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Migrate
pkg/kubeto errkit.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan