Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace many minor usages of errors with errkit #3228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Nov 14, 2024

Change Overview

Bunch of changes in different small packages

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@e-sumin e-sumin force-pushed the errkit_migration_8_remainder branch 6 times, most recently from 0ad85f4 to 2d9d538 Compare November 21, 2024 16:24
@e-sumin e-sumin force-pushed the errkit_migration_8_remainder branch 7 times, most recently from 3ff70e5 to 23241c5 Compare November 22, 2024 09:58
@hairyhum
Copy link
Contributor

@e-sumin can you split it into several PRs? 79 files is a bit too much to review all at once. Can be arbitrary if they don't depend on each other.

@e-sumin e-sumin force-pushed the errkit_migration_8_remainder branch from b771d1b to 88e2e79 Compare November 29, 2024 13:16
@e-sumin e-sumin force-pushed the errkit_migration_8_remainder branch from 88e2e79 to d637469 Compare November 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants