-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated k8s packages to 1.30 and method calls #3221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @artem-akulshin could you please run make codegen
to verify if any updates in generated code is required?
go.mod
Outdated
require ( | ||
github.com/go-ini/ini v1.67.0 // indirect | ||
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70 // indirect | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to merge this require
section with existing one for // indirect
deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done
@artem-akulshin could you please confirm if you have verified whether updates in auto generated code are required with |
I did, and some updates were required to the codegen.sh script. Newly generated code has little difference, but it is non-zero and I would appreciate an advice on how to test it, if automated tests does not cover this piece... |
Thank, automated tests takes care of that |
Change Overview
Updating K8S APIs to 1.30, and fix some problems because of that change
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan