Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated k8s packages to 1.30 and method calls #3221

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

artem-akulshin
Copy link
Contributor

Change Overview

Updating K8S APIs to 1.30, and fix some problems because of that change

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @artem-akulshin could you please run make codegen to verify if any updates in generated code is required?

go.mod Outdated
Comment on lines 238 to 241
require (
github.com/go-ini/ini v1.67.0 // indirect
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70 // indirect
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to merge this require section with existing one for // indirect deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@PrasadG193
Copy link
Contributor

@artem-akulshin could you please confirm if you have verified whether updates in auto generated code are required with make codegen?

@artem-akulshin
Copy link
Contributor Author

@artem-akulshin could you please confirm if you have verified whether updates in auto generated code are required with make codegen?

I did, and some updates were required to the codegen.sh script. Newly generated code has little difference, but it is non-zero and I would appreciate an advice on how to test it, if automated tests does not cover this piece...

@PrasadG193
Copy link
Contributor

Thank, automated tests takes care of that

@mergify mergify bot merged commit 5c7ac49 into master Nov 12, 2024
22 checks passed
@mergify mergify bot deleted the keu/artem.akulshin/bump_k8s_packages_to_1.30 branch November 12, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants