Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gcloud auth plugin in kanister build image #3210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

When running the integration test using make integration-test we are asked to install minio using make install-minio but if our k8s cluster is gke and in the kuebconfig gcloud auth plugin is used, make install-minio fails with below error

Unable to connect to the server: getting credentials: exec: executable gke-gcloud-auth-plugin not found

It looks like you are trying to use a client-go credential plugin that is not installed.

To learn more about this feature, consult the documentation available at:
      https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins

Install gke-gcloud-auth-plugin for use with kubectl by following https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-access-for-kubectl#install_plugin

And this seems to be happening because our build image doesn't have gcloud auth plugin installed. This PR installs that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@@ -13,6 +13,13 @@ RUN curl -fsSL https://download.docker.com/linux/debian/gpg | gpg --dearmor -o /
RUN apt update && apt install -y docker-ce docker-ce-cli containerd.io \
&& apt-get clean

RUN apt-get install apt-transport-https ca-certificates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not adding this in the first apt-get install above (line 7)?

Also, remove the apt-get clean above (line 14) and move it to after the last apt-get install below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julio-lopez ,
Thank you for the review, I can work on above suggestions.
But I initially thought that we would just need to install gcloud and gcloud auth plugin, in the kanister build image, and things would work but that doesn't seem to be the case.

We will also have to set up gcloud authentication, which I think needs to be discussed with the team and then worked on, so I am planning to park this for now and work on it after discussing this in community call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants