Fix incorrect conversion between int types #3205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Fixes #3202
In the older version of the logic where we were reading replicas of workload in
ScaleWorkload
function; if val (string type) has an int value that is beyond the range of int32, even though callstrconv.Atoi(val)
would succeed, the next ofreplicas = int32(v)
would result into unexpected result because the val is beyond what can be accommodated into int32 type.This change fixes that.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan