Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestParallelStdout: Wait for process to terminate #3200

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Oct 25, 2024

Change Overview

Should fix error:

[2024-10-25T00:23:22.786Z] === RUN   Test/KanXSuite/TestParallelStdout
...
[2024-10-25T00:23:22.811Z]     kanx_test.go:264: 
[2024-10-25T00:23:22.811Z]         error:
[2024-10-25T00:23:22.811Z]           values are not equal
[2024-10-25T00:23:22.811Z]         got:
[2024-10-25T00:23:22.811Z]           s"PROCESS_STATE_RUNNING"
[2024-10-25T00:23:22.811Z]         want:
[2024-10-25T00:23:22.811Z]           s"PROCESS_STATE_FAILED"
[2024-10-25T00:23:22.811Z]         stack:
[2024-10-25T00:23:22.811Z]           /root/go/pkg/mod/github.com/kanisterio/[email protected]/pkg/kanx/kanx_test.go:264
[2024-10-25T00:23:22.811Z]             c.Assert(ps[0].GetState(), Equals, ProcessState_PROCESS_STATE_FAILED)
[2024-10-25T00:23:22.811Z]           /usr/local/go/src/reflect/value.go:596
[2024-10-25T00:23:22.811Z]             call(frametype, fn, stackArgs, uint32(frametype.Size()), uint32(abid.retOffset), uint32(frameSize), &regArgs)
[2024-10-25T00:23:22.811Z]           /usr/local/go/src/reflect/value.go:380
[2024-10-25T00:23:22.811Z]             return v.call("Call", in)
[2024-10-25T00:23:22.811Z]           /codefresh/volume/k10/go/src/kasten.io/qt-check/suite.go:110
[2024-10-25T00:23:22.811Z]             test.Func.Call([]reflect.Value{reflect.ValueOf(suite), reflect.ValueOf(tc)})

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@tdmanv tdmanv force-pushed the tom/fix-kanx-parallel-test branch from a6bfb90 to 9df86e6 Compare October 25, 2024 04:36
@tdmanv tdmanv added the kueue label Oct 28, 2024
@mergify mergify bot merged commit c1a82aa into master Oct 28, 2024
22 checks passed
@mergify mergify bot deleted the tom/fix-kanx-parallel-test branch October 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants