build: bump golangci-lint version in build image #3195
Conversation
Old versio of golangci-lint has a memory leak causing it to crash with oom in recent go versions. Updated golangci-lint version. Fixed some lint errors.
| @@ -55,22 +55,22 @@ func (*deleteRDSSnapshotFunc) Name() string { | |||
| return DeleteRDSSnapshotFuncName | |||
| } | |||
|
|
|||
| func deleteRDSSnapshot(ctx context.Context, snapshotID string, profile *param.Profile, dbEngine RDSDBEngine) (map[string]interface{}, error) { | |||
There was a problem hiding this comment.
Should this be part of this PR?
There was a problem hiding this comment.
This fixes an unparam linter warning.
There was a problem hiding this comment.
@KastenMike I am assuming this was flagged by a linter as part of the upgrade. @hairyhum can confirm.
If that's the case, there are 2 options:
- Put all the changes in a single PR, like this one; or
- 2 PRs in this order: the first one addressing the linter warnings, and the second one upgrading the linter version.
There was a problem hiding this comment.
Upgrading linter version is a github action, which I've already run, so it's just a matter of getting it to the master codebase
| @@ -134,7 +134,7 @@ func createVolumeSnapshot(ctx context.Context, tp param.TemplateParams, cli kube | |||
| } | |||
| wg.Wait() | |||
|
|
|||
| err := fmt.Errorf(strings.Join(errstrings, "\n")) | |||
| err := fmt.Errorf("%s", strings.Join(errstrings, "\n")) | |||
There was a problem hiding this comment.
It seems that this should use errors.New
| err := fmt.Errorf("%s", strings.Join(errstrings, "\n")) | |
| err := errors.New(strings.Join(errstrings, "\n")) |
Question unrelated to this PR why are newlines (\n) being used inside the error message?
There was a problem hiding this comment.
Or maybe errkit, but I was trying to keep the changes minimal.
There was a problem hiding this comment.
Changed to errkit because we already have it in this file.
Change Overview
Old version of golangci-lint has a memory leak causing it to crash with oom in recent go versions.
Updated golangci-lint version in build image.
Fixed lint errors.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan