[minor] Prefer signal.NotifyContext to signal.Notify in kanx

[tdmanv]

Change Overview

signal.NotifyContext has been around since 1.16 and we should prefer it to signal.Notify.

https://pkg.go.dev/os/signal#NotifyContext

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test
• 🏗️ Build

Issues

• fixes #issue-number

Test Plan

Start Server

Server

./kando process server
{"File":"pkg/kando/process_server.go","Function":"github.com/kanisterio/kanister/pkg/kando.runProcessServer","Line":41,"address":{"Name":"/tmp/kanister.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-10-10T11:21:31.101779-07:00"}

Run Process

Client

./kando process client create -- tail -f /dev/null
Created process: pid:88226 state:PROCESS_STATE_RUNNING

Server

{"File":"pkg/kanx/kanx_grpc.pb.go","Function":"github.com/kanisterio/kanister/pkg/kanx._ProcessService_CreateProcesses_Handler","Line":190,"level":"info","msg":"pid:88226 state:PROCESS_STATE_RUNNING","stderr":"/var/folders/bf/c6ydxpp17p76y97j_yy_6n_m0000gp/T/kando.4170550590.stderr","stdout":"/var/folders/bf/c6ydxpp17p76y97j_yy_6n_m0000gp/T/kando.1518022560.stdout","time":"2024-10-10T11:23:11.573424-07:00"}

Send Interrupt ()

Server

^C{"File":"/opt/homebrew/Cellar/go/1.23.1/libexec/src/runtime/asm_arm64.s","Function":"runtime.goexit","Line":1223,"level":"info","msg":"Gracefully stopping. Parent context canceled","time":"2024-10-10T11:23:28.827767-07:00"}
{"File":"/opt/homebrew/Cellar/go/1.23.1/libexec/src/runtime/asm_arm64.s","Function":"runtime.goexit","Line":1223,"level":"info","msg":"pid:88226 state:PROCESS_STATE_FAILED exitCode:-1 exitErr:\"signal: interrupt\"","time":"2024-10-10T11:23:28.828545-07:00"}

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[aaron-kasten]

Looks good!

[julio-lopez]

nit: make it explicit here can => cancel. It becomes easier to understand for the human reader.

[tdmanv]

Based on https://go.dev/wiki/CodeReviewComments#variable-names, maybe this should be c. The readable scope of the variable is 1 line, so i'd suggest a short variable name

[julio-lopez]

Tom, yes, in general variable names should be proportional to the context and so on.
In this case, cancel stop would be a better name for clarity, especially for the casual reviewer that looks at this code. It's about making it easy to understand the intent.