Group check.v1 package with third-party package

[anishbista60]

Change Overview

• Remove the . from . "gopkg.in/check.v1" and then group it with third-party package . Use check prefix when you are gettting issue after removing .

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test
• 🏗️ Build

Issues

• fixes Group check.v1 package with third-party package.  #3136

Test Plan

• 💪 Manual
• ⚡ Unit test
• Enable gci linter and remove the dot which is present under gci.sections in .golangci.yml (Just to check that whether gci throwing error or not, which will not be included as a part of this PR)
• Then, Run make golint for testing.
• 💚 E2E

[anishbista60]

@viveksinghggits Please take a look once. So, i can move forward.
#3094

[viveksinghggits]

@viveksinghggits Please take a look once. So, i can move forward. #3094

can you please add the test plan for the PR @anishbista60 .

[anishbista60]

@viveksinghggits sure i'll do it but the changes are not completed yet.
could you please verify the changes ? if it's looks good then i can move forward for other files.

[viveksinghggits]

@anishbista60 yes the current changes look good.

[anishbista60]

@viveksinghggits Everything Done. Please ! have a look. Works fine in my machine.

[julio-lopez]

@anishbista60
For future reference, it makes sense to split large changes like this where 100s of files are modified with the same type of change. For example, instead o single large PR, have individual PRs with say 20 files per PR. That makes them easier to review individually, and also merge, as it reduces the probability of conflicts, and if there are conflicts, then other non-conflicting PRs can be merged.

[julio-lopez]

@anishbista60
🥇Thanks for doing this.

🎉 🎊 🚀 🥳

[anishbista60]

@anishbista60 For future reference, it makes sense to split large changes like this where 100s of files are modified with the same type of change. For example, instead o single large PR, have individual PRs with say 20 files per PR. That makes them easier to review individually, and also merge, as it reduces the probability of conflicts, and if there are conflicts, then other non-conflicting PRs can be merged.

Sure , ok.

[pavannd1]

@anishbista60 Please verify all the checks in this PR to ensure we haven't flipped anything. I found one issue causing test failures here.

One of the reasons to break down large PRs into multiple smaller PRs - it'll be easier for reviewers to catch such issues.

[anishbista60]

@pavannd1 Sorry ! for difficulty while reviewing and obviously going to 100 of files would be difficult. I walked though entire changes and doesn't get any error except yours ones.

[anishbista60]

looks you already fix that. thank you