Enabled lll linter for test packages
#3117
Conversation
|
@julio-lopez please look into this PR. Iam trying to finish off these linter's issue. |
There was a problem hiding this comment.
@anishbista60 Have you run the tests that are modified in this PR?
It seems that some of them will fail.
| @@ -121,7 +121,32 @@ func (kParse *KopiaParseUtilsTestSuite) TestSnapshotInfoFromSnapshotCreateOutput | |||
| { | |||
| output: `Snapshotting u2@h2:/tmp/aaa1 ... | |||
| * 0 hashing, 1 hashed (2 B), 3 cached (4 B), uploaded 5 KB, estimating... | |||
| {"id":"00000000000000000000001","source":{"host":"h2","userName":"u2","path":"/tmp/aaa1"},"description":"","startTime":"2021-05-26T05:29:07.206854927Z","endTime":"2021-05-26T05:29:07.207328392Z","rootEntry":{"name":"aaa1","type":"d","mode":"0755","mtime":"2021-05-19T15:45:34.448853232Z","obj":"ka68ba7abe0818b24a2b0647aeeb02f29","summ":{"size":0,"files":1,"symlinks":0,"dirs":1,"maxTime":"2021-05-19T15:45:34.448853232Z","numFailed":0}}} | |||
| { | |||
There was a problem hiding this comment.
I may be wrong, but it seems that this test will fail.
There was a problem hiding this comment.
@julio-lopez let me resolve merge confllict
There was a problem hiding this comment.
@julio-lopez the changes that i made here is to log file and which will be changed every time . So, enabling this lll linter does not make sense. what do you think ?
There was a problem hiding this comment.
Have you run the test?
There was a problem hiding this comment.
Are you asking for Entire test cases or golint only? .Talking about linter test case, it has passed .
There was a problem hiding this comment.
Tests as well, it looks like those are going to fail
There was a problem hiding this comment.
yeah, make test went to failure .
ok github.com/kanisterio/kanister/pkg/virtualfs 0.011s
FAIL
real 360.99
user 0.05
sys 1.52
make[1]: *** [Makefile:217: run] Error 1
make[1]: Leaving directory '/home/anishbista/kanister'
make: *** [Makefile:165: go-test] Error 2
But honestly unable to figure out the reason behind it .
could you run the test cases here ?
There was a problem hiding this comment.
Hi @anishbista60,
could you run the test cases here ?
If it's failing for you, it's going to fail for anyone else who tries to run the test.
But honestly unable to figure out the reason behind it .
do you need help figuring out why the test is failing? Do you understand what exactly the test is doing?
Signed-off-by: Anish Bista <[email protected]>
|
@anishbista60 Please rebase and resolve conflicts on this PR. |
Change Overview
lllfor test packagesPull request type
Please check the type of change your PR introduces:
Issues
Test Plan