Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dupl linter for test package #3074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable dupl linter for test package #3074

wants to merge 1 commit into from

Conversation

anishbista60
Copy link
Contributor

@anishbista60 anishbista60 commented Aug 28, 2024 •
edited
Loading

Change Overview

Enabled dupl linter for test package

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@anishbista60
Removed linter: dupl
34cdc1d 
Signed-off-by: Anish Bista <[email protected]>
@anishbista60
Copy link
Contributor Author

yet to fix some issue .

@pavannd1
Copy link
Contributor

Same as the other PR. Please add some description to explain the changes.

@anishbista60
Copy link
Contributor Author

anishbista60 commented Aug 29, 2024 •
edited
Loading

Same as the other PR. Please add some description to explain the changes.

here also wrong

@anishbista60 anishbista60 changed the title Removed linter: dupl Enable dupl linter for test package Aug 29, 2024
julio-lopez
julio-lopez requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇Thanks for doing this.

This is going in the right direction. It seems that it still needs work.

pkg/function/scale_test.go Show resolved Hide resolved
pkg/function/scale_test.go Show resolved Hide resolved
@anishbista60
Copy link
Contributor Author

@julio-lopez I'll try to finish off these linter thing as fast as I can . Just please assist me in review❤️. Thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio-lopez julio-lopez julio-lopez requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anishbista60 @pavannd1 @julio-lopez