Enable stylecheck linter in test files
#3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
looks fine in my local machine |
|
@anishbista60 could you please add some description above to explain why the linter has been removed? I see you have linked another PR here but it's unclear why these changes are required. |
anishbista60
changed the title
stylecheck linter for test package
|
@pavannd1 sorry it is actually beinng enabled. mistake in description |
julio-lopez
requested changes
Sep 4, 2024
Signed-off-by: Anish Bista <[email protected]>
anishbista60
force-pushed
the
style-check
branch
from
1cace4f to
d54ee39
Compare
|
@julio-lopez looks fine in my machine now . Let's merge it . |
julio-lopez
changed the title
stylecheck linter for test package stylecheck linter in test files
julio-lopez
approved these changes
Sep 5, 2024
|
🥇Thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Enables the linter
stylecheck. See #2962.Pull request type
Please check the type of change your PR introduces:
Issues
errchecklinter for test packages #3034Test Plan