-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(docker): bump kopia version for kanister-tools #3063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpinning may have undesired side-effects, such as
- inadvertently upgrading and picking up a different version of kopia on every build (or invocation of goreleaser).
- not being able reprodude a released version with the same version of kopia that was used when it got released.
- also, there is a specific kopia dependency in
go.mod
, which is kept in sync with the one here. The version used here should be pulled fromgo.mod
at build time.
That's a good point, but this means we didn't keep kopia version in |
95831d4
to
22672c5
Compare
Bumped kopia commit in go.mod and goreleaser. |
22672c5
to
8e6180e
Compare
8e6180e
to
e4c47b4
Compare
Change Overview
Use current master of kopia to build kanister-tools imageNot using the current master because it messes up with the go toolchain at the moment.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan