Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(docker): bump kopia version for kanister-tools #3063

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Aug 23, 2024

Change Overview

Use current master of kopia to build kanister-tools image

Not using the current master because it messes up with the go toolchain at the moment.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinning may have undesired side-effects, such as

  • inadvertently upgrading and picking up a different version of kopia on every build (or invocation of goreleaser).
  • not being able reprodude a released version with the same version of kopia that was used when it got released.
  • also, there is a specific kopia dependency in go.mod, which is kept in sync with the one here. The version used here should be pulled from go.mod at build time.

@julio-lopez julio-lopez requested a review from pavannd1 August 24, 2024 00:19
@hairyhum
Copy link
Contributor Author

also, there is a specific kopia dependency in go.mod, which is kept in sync with the one here. The version used here should be pulled from go.mod at build time.

That's a good point, but this means we didn't keep kopia version in go.mod up to date. Pulling version from go.mod should be possible.

@hairyhum hairyhum force-pushed the deps-kopia-kanister-tools branch from 95831d4 to 22672c5 Compare October 11, 2024 17:11
@hairyhum hairyhum changed the title deps(docker): unpin kopia version for kanister-tools deps(docker): bump kopia version for kanister-tools Oct 11, 2024
@hairyhum
Copy link
Contributor Author

Bumped kopia commit in go.mod and goreleaser.
Not using the latest version because we have issue updating the build image right now https://github.com/kanisterio/kanister/actions/runs/11295843718

@hairyhum hairyhum force-pushed the deps-kopia-kanister-tools branch from 22672c5 to 8e6180e Compare October 11, 2024 17:14
@hairyhum hairyhum requested a review from julio-lopez October 11, 2024 17:14
@hairyhum hairyhum force-pushed the deps-kopia-kanister-tools branch from 8e6180e to e4c47b4 Compare October 11, 2024 17:16
@pavannd1 pavannd1 added the kueue label Oct 18, 2024
@mergify mergify bot merged commit 28dec8e into master Oct 18, 2024
18 checks passed
@mergify mergify bot deleted the deps-kopia-kanister-tools branch October 18, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants