-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Cache Size Limits for kopia server start #3060
Merged
mergify
merged 12 commits into
master
from
add-support-for-cache-size-limit-flags-for-kopia-server
Sep 5, 2024
Merged
Add Support for Cache Size Limits for kopia server start #3060
mergify
merged 12 commits into
master
from
add-support-for-cache-size-limit-flags-for-kopia-server
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: Rajat Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PrasadG193
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… args := commonArgs(&CommandArgs{ConfigFilePath: cmdArgs.ConfigFilePath, LogDirectory: cmdArgs.LogDirectory}) Signed-off-by: Rajat Gupta <[email protected]>
@r4rajat can you take a look at CI failure? |
Put args = cmdArgs.kopiaCacheArgs(args, cmdArgs.CacheDirectory) back to original location
mergify
bot
deleted the
add-support-for-cache-size-limit-flags-for-kopia-server
branch
September 5, 2024 14:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add Support for Cache Size Limits for command
kopia server start
This PR will enable support for following flags for
kopia server start
command--cache-directory
--content-cache-size-limit-mb
--metadata-cache-size-limit-mb
without these flags kopia server sometimes takes a lot of storage for caching in cases when we have large data to backup or restore.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan