-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate the label/annotation in validate method of Kanister function #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these args are going to be named the same for all the kanister functions that support these arguments, it's better to have them as a const and use that everywhere. It will help us when we try to get labels and annotations from blueprints.
viveksinghggits
force-pushed
the
ann-labels-functions
branch
from
August 14, 2024 10:28
1a2dcc9
to
60feaae
Compare
1. Remove duplicate const declarations 2. Reformat function calls to have them in newline
Since these args are going to be named the same for all the kanister functions that support these arguments, it's better to have them as a const and use that everywhere. It will help us when we try to get labels and annotations from blueprints.
viveksinghggits
force-pushed
the
validate-ann-labels-functions
branch
from
August 19, 2024 10:40
bd3d154
to
a7e8e71
Compare
While validating the labels and annotations, when the validate resulted into error, we returned `nil` instead of `err`. This commit fixes that and adds some comments into some functions.
viveksinghggits
changed the title
Validate the label/annotation validity in validate method of kan func…
Validate the label/annotation in validate method of Kanister function
Aug 19, 2024
PrasadG193
reviewed
Aug 20, 2024
PrasadG193
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
As part of
Validate
method of a Kanister function we were just checking if the correct arguments to that functions are provided or not. But As part of this PR #3013 we are introducing two more two more args (podLabels
andpodAnnotations
) to the kanister functions that create new pod.This PR enhances the
Validate
method of the functions so that we can check validity of the configured labels and annotations as well.This is the
Validate
method also eventually gets called (by blueprint's validating webhook) when we create a blueprint, so implementing this make sure that if we create a blueprint by specifying wrong labels/annotations to the kanister functions, the validating webhook rejects the request.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan