nodeset support and path-style s3 endpoint #2974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhum
approved these changes
Jul 26, 2024
| } | ||
| } | ||
| ' | ||
|
|
||
| echo "delete the snap $SNAPSHOT_NAME" | ||
| curl -k -u "elastic:$PASSWORD" -X DELETE "${ES_URL}/_snapshot/k10_repo/$SNAPSHOT_NAME?pretty" | ||
| echo "Deletion of $SNAPSHOT_NAME was successful" | ||
|
|
||
| echo "Deletion of $SNAPSHOT_NAME was successful" |
There was a problem hiding this comment.
Suggested change
| echo "Deletion of $SNAPSHOT_NAME was successful" | |
| echo "Deletion of $SNAPSHOT_NAME was successful" | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR introduce support for elasticsearch cluster that have more than one nodeset (it was not supported before) and set up path_style_access=true when using a non AWS S3 endpoint otherwise the url domain is built with the name of the bucket and the region and this setting is not supported most of the time for s3 compliant endpoint.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan