Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errkit migration 3 (pkg/app) #2892

Merged
merged 41 commits into from
Jun 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
0afc932
When error happens during `kube.Exec`, error should capture tail of s…
e-sumin Nov 15, 2023
b998a67
Move `ExecError` definition from `PodCommandExecutor` to `kube.Exec`
e-sumin Nov 15, 2023
1e0dc7f
`PodCommandExecutor` should just pass an `ExecError` produced by `kub…
e-sumin Nov 15, 2023
af8489a
Merge branch 'master' into common-exec-error-handling
e-sumin Dec 1, 2023
bc06376
`ExecWithOptions` should not return stdout / stdin
e-sumin Nov 30, 2023
ed20ccd
Adjust `PodCommandExecutor` and tests
e-sumin Nov 30, 2023
491a1e2
Add errkit dependency
e-sumin Dec 7, 2023
55fcf6a
pkg/kube migration
e-sumin Dec 7, 2023
fa10085
Merge branch 'master' into errkit-migration
e-sumin Dec 7, 2023
b4f81ce
go mod tidy
e-sumin Dec 7, 2023
f929fd7
Satisfy linter
e-sumin Dec 7, 2023
8ab6c25
Do not invoke `errkit.Wrap` if err is nil
e-sumin Dec 11, 2023
ac0c1fd
Remove redundant else statement
e-sumin Dec 11, 2023
544e45f
Merge branch 'master' into errkit-migration-1
e-sumin Dec 13, 2023
7b1080b
Do not invoke `errkit.Wrap` if err is nil
e-sumin Dec 14, 2023
8b3aabb
Add special errkit.Error message checker
e-sumin Dec 14, 2023
599ab3f
Merge remote-tracking branch 'origin/master' into errkit-migration-1
e-sumin Mar 19, 2024
84bc700
Bump errkit version
e-sumin Mar 19, 2024
2921b99
Fix NewPureError => NewSentinelErr
e-sumin Mar 19, 2024
865afc4
Get rid of specific errkit.Error checker, make it common regex checker
e-sumin Mar 20, 2024
b18e381
Refer initial release of errkit
e-sumin Mar 20, 2024
6ed89fb
Merge remote-tracking branch 'origin/master' into errkit-migration-1
e-sumin May 6, 2024
562bee1
Add `errkit` dependency
e-sumin May 6, 2024
b980fe9
Fix typos
e-sumin May 17, 2024
24d3147
Replace imports
e-sumin May 17, 2024
336dba7
Replace errors.New without parameters
e-sumin May 17, 2024
cfe67f6
Replace errors.New with parameters
e-sumin May 17, 2024
d0c68ee
Replace fmt.Errorf without parameters with errkit.New
e-sumin May 17, 2024
d34f905
Replace errors.Errorf with errors.New
e-sumin May 17, 2024
e161520
Replace fmt.Errorf for env var is not set
e-sumin May 17, 2024
03a53d5
Replace errors.Wrap and errors.Wrapf without parameters
e-sumin May 17, 2024
d6f6a4d
Replace errors.Wrapf with stderr
e-sumin May 17, 2024
7c100a8
Replace errors.Wrapf with stderr and app name
e-sumin May 17, 2024
0a3e030
Replace errors.Wrapf with stderr and stdout
e-sumin May 17, 2024
e907227
Replace errors.Wrap with named parameters
e-sumin May 17, 2024
60220da
Replace errors.Wrapf for Error getting aws config
e-sumin May 17, 2024
1c0bb40
Replace errors.Wrapf for Error getting pod and container name
e-sumin May 17, 2024
2f9439d
Other replacements
e-sumin May 17, 2024
156b18a
Merge branch 'master' into errkit-migration-3
e-sumin Jun 19, 2024
0818a15
apply goimport
e-sumin Jun 25, 2024
d2897ce
Merge branch 'master' into errkit-migration-3
mergify[bot] Jun 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refer initial release of errkit
  • Loading branch information
e-sumin committed Mar 21, 2024
commit b18e381985a9cf4c77315d64175b9dff4892d3e6
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -214,7 +214,7 @@ require (
)

require (
github.com/kanisterio/errkit v0.0.0-20240319102630-5ea0bbcfe0c3
github.com/kanisterio/errkit v0.0.1
github.com/kanisterio/safecli v0.0.7
)

4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -354,8 +354,8 @@ github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnr
github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo=
github.com/jstemmer/go-junit-report v0.0.0-20190106144839-af01ea7f8024/go.mod h1:6v2b51hI/fHJwM22ozAgKL4VKDeJcHhJFhtBdhmNjmU=
github.com/jstemmer/go-junit-report v0.9.1/go.mod h1:Brl9GWCQeLvo8nXZwPNNblvFj/XSXhF0NWZEnDohbsk=
github.com/kanisterio/errkit v0.0.0-20240319102630-5ea0bbcfe0c3 h1:EWdynzD4V2Mza/RdZTilKVBbKK2zeGsE23pMQq3xqwI=
github.com/kanisterio/errkit v0.0.0-20240319102630-5ea0bbcfe0c3/go.mod h1:ViQ6kPJ2gTJDEvRytmwde7pzG9/sndObF9BPZoEZixc=
github.com/kanisterio/errkit v0.0.1 h1:oT8n9IknGcfE5xlc2stczMTKrDWEAifC/laAk8rBDpQ=
github.com/kanisterio/errkit v0.0.1/go.mod h1:ViQ6kPJ2gTJDEvRytmwde7pzG9/sndObF9BPZoEZixc=
github.com/kanisterio/safecli v0.0.7 h1:PsSbAs6MPox5h4zA9HT/dn5Qi5BtSVFq9c0Oh2sfRwE=
github.com/kanisterio/safecli v0.0.7/go.mod h1:KBraqj8mdv2cwAr9wecknGUb8jztTzUik0r7uE6yRA8=
github.com/kastenhq/check v0.0.0-20180626002341-0264cfcea734 h1:qulsCaCv+O2y9/sQ9nd5KChnAgFOWakTHQ9ZADjs6DQ=