-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ephemeral pods created as part of kanister functions with JobID label #2778
Conversation
@mabhi are we just going to handle |
Yes. Accounted additional pods as suggested in a separate PR. |
0f7a1da
to
9037165
Compare
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
This reverts commit 444786f.
Signed-off-by: Abhijit Mukherjee <[email protected]>
9037165
to
65f92ea
Compare
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
…s funcs Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
Signed-off-by: Abhijit Mukherjee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestions about formatting and optimization in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions about additional validation we can add in the test.
Change Overview
Due to an ongoing work regarding identifying ephemeral pods those get spawned during various operations as part of some of the kanister functions, we need to mark these pod with some labels. One such pre-decided label for these pods is
kanister.io/JobID
. This label will help:Right now the flow of this label information is, with the instantiation of actionset against a blueprint that services various kanister functions is triggered from an external application, and let's say if this label populated with a JobID, then this label [key: value] pair is added in entirerity to the temporary pod, so we can track it.
This PR handle cases when the
kube-task
labelled pods invoke kanister function that has a context.Context instance passed that contains a key-value pair corresponding to the pre-decided label, then it will make its way to the pods label selector map in addition to others if present already.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan