Set cluster_name var in logs vars separately and not in init
#2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we set the `cluster_name` field in log variables (extran fields that are printed in logs), inside the `init` function of `log` package, we would un necessarily be calling k8s api even from the places where we don't have to do anything with the k8s api. To fix this, this commit introduces a new function that can be used to setup that field in the logs vars and that function will only be called from the places where we need the logs to have to the `cluster_name` field, for example `kanctl`, `controller` and `repository-controller`.
|
In current version Build new binary and test these
|
hairyhum
approved these changes
Mar 21, 2024
mabhi
pushed a commit
that referenced
this pull request
Mar 28, 2024
If we set the `cluster_name` field in log variables (extran fields that are printed in logs), inside the `init` function of `log` package, we would un necessarily be calling k8s api even from the places where we don't have to do anything with the k8s api. To fix this, this commit introduces a new function that can be used to setup that field in the logs vars and that function will only be called from the places where we need the logs to have to the `cluster_name` field, for example `kanctl`, `controller` and `repository-controller`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
If we set the
cluster_namefield in log variables (extran fields that are printed in logs), inside theinitfunction oflogpackage, we would un necessarily be calling k8s api even from the places where we don't have to do anything with the k8s api.To fix this, this commit introduces a new function that can be used to setup that field in the logs vars and that function will only be called from the places where we need the logs to have to the
cluster_namefield, for examplekanctl,controllerandrepository-controller.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Detailed steps are part of a comment below.