Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): add pre-release workflow to create version bump PR #2774

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Mar 20, 2024

Change Overview

Currently release process is happening outside of github workflows. This is a first step to move it there.

Pre-release workflow can be run from workflow dispatch in github actions and will create a PR with version update.

I've also changed the version bump PR title because it's not only updating docs

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

Test runs can be found in https://github.com/kanisterio/kanister/actions/workflows/pre-release.yml

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@hairyhum
Copy link
Contributor Author

Added RELEASE.md with kanister release instructions. It currently describes the process with reno release notes, which are not merged yet.

@julio-lopez julio-lopez changed the title build(release): add pre-release workflow to creat version bump PR build(release): add pre-release workflow to create version bump PR Apr 4, 2024
@hairyhum hairyhum force-pushed the ci-pre-release branch 2 times, most recently from 3826b05 to 7468b5e Compare April 10, 2024 19:27
@hairyhum hairyhum changed the base branch from master to reno-changelog April 10, 2024 19:28
@hairyhum
Copy link
Contributor Author

Rebased it on reno-changelog branch

.github/workflows/pre-release.yml Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@hairyhum hairyhum requested a review from pavannd1 May 10, 2024 16:19
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/pre-release.yml Show resolved Hide resolved
PRERELEASE_DOCS_BRANCH: 'dg8d45z'

jobs:
## TODO we can add a condition like github.actor.role == 'Maintainer' to limit trigger to maintainers only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do this as part of this PR itself? I think we should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not yet supported, but there's active discussion ongoing. When it's implemented, we can do that.

Copy link
Contributor

@e-sumin e-sumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from reno-changelog to master June 19, 2024 14:51
@hairyhum hairyhum added the kueue label Jun 20, 2024
@hairyhum hairyhum merged commit f5bdd5b into master Jun 20, 2024
14 of 15 checks passed
@hairyhum hairyhum deleted the ci-pre-release branch June 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants