-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kopia s3 and s3 compliant storage flags #2659
Conversation
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
Signed-off-by: pavel.larkin <[email protected]>
@@ -0,0 +1,68 @@ | |||
package s3 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ArgTest
a utilitity to be used across different packages. This doesnt seem relevant to s3 package. Should we move it to a different package or utils package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I will move it to pkg/kopia/cli/internal/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments
Signed-off-by: pavel.larkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Change Overview
This PR is the 7th in the series of PRs that will add a new way to build Kopia CLI commands.
PR Train:
This PR introduces storage s3 and s3 compliant flag structures which will be used to build storage flags for s3 and s3 compliant storages.
Pull request type
Please check the type of change your PR introduces:
Test Plan