Errkit migration 2 (pkg/kopia) #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdout/stderr streams.
…e.ExecWithOptions`
Output could be obtained by writers passed via `ExecOptions`
# Conflicts: # pkg/kube/pod.go
e-sumin
requested review from
pavannd1,
ankitjain235,
PrasadG193 and
viveksinghggits
hairyhum
reviewed
Mar 12, 2024
e-sumin
force-pushed
the
errkit-migration-2
branch
from
92cfbdc to
20d1867
Compare
e-sumin
force-pushed
the
errkit-migration-1
branch
from
e1c3136 to
2921b99
Compare
e-sumin
force-pushed
the
errkit-migration-2
branch
2 times, most recently
from
b1ba71b to
4b6c62f
Compare
e-sumin
force-pushed
the
errkit-migration-1
branch
from
d5d5249 to
b18e381
Compare
e-sumin
force-pushed
the
errkit-migration-2
branch
from
4b6c62f to
32661a3
Compare
e-sumin
force-pushed
the
errkit-migration-2
branch
from
32661a3 to
4e5ee80
Compare
e-sumin
force-pushed
the
errkit-migration-2
branch
from
4e5ee80 to
107d323
Compare
hairyhum
approved these changes
Jun 19, 2024
PrasadG193
approved these changes
Jun 20, 2024
Comment on lines
27
to
28
| "github.com/kanisterio/kanister/pkg/field" | ||
| "github.com/kanisterio/kanister/pkg/log" |
There was a problem hiding this comment.
Let's put internal packages in a separate group
pkg/kopia/repository/client.go
Outdated
Comment on lines
29
to
30
| "github.com/kopia/kopia/repo" | ||
| "github.com/kopia/kopia/repo/content" |
There was a problem hiding this comment.
Please keep kanister and other packages into separate groups
Comment on lines
20
to
23
| "k8s.io/client-go/kubernetes" | ||
|
|
||
| "github.com/kanisterio/errkit" | ||
| "github.com/kanisterio/kanister/pkg/kopia/command" |
There was a problem hiding this comment.
Suggested change
| "k8s.io/client-go/kubernetes" | |
| "github.com/kanisterio/errkit" | |
| "github.com/kanisterio/kanister/pkg/kopia/command" | |
| "k8s.io/client-go/kubernetes" | |
| "github.com/kanisterio/errkit" | |
| "github.com/kanisterio/kanister/pkg/kopia/command" |
errkit package should be considered as external package and put it into separate group
pkg/kopia/snapshot/snapshot.go
Outdated
Comment on lines
24
to
33
| "github.com/kanisterio/errkit" | ||
| "github.com/kanisterio/kanister/pkg/kopia" | ||
| "github.com/kanisterio/kanister/pkg/kopia/repository" | ||
| "github.com/kopia/kopia/fs" | ||
| "github.com/kopia/kopia/repo" | ||
| "github.com/kopia/kopia/repo/manifest" | ||
| "github.com/kopia/kopia/snapshot" | ||
| "github.com/kopia/kopia/snapshot/policy" | ||
| "github.com/kopia/kopia/snapshot/snapshotfs" | ||
| "github.com/pkg/errors" | ||
|
|
||
| "github.com/kanisterio/kanister/pkg/kopia" | ||
| "github.com/kanisterio/kanister/pkg/kopia/repository" |
There was a problem hiding this comment.
github.com/kanisterio/kanister are internal packages, so should be kept in a separate group
pkg/kopia/snapshot/stream.go
Outdated
Comment on lines
25
to
26
| "github.com/kanisterio/kanister/pkg/kopia" | ||
| "github.com/kanisterio/kanister/pkg/kopia/repository" |
has been applied, so now our packages are properly sorted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
In accordance with decision to migrate to our own errors package (look here #1838), this PR contains migration of pkg/kopia to errkit package.
Further migration PRs are expected.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan