When CreatePod fails, dump pod options #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-sumin
force-pushed
the
dump-pod-settings-on-create-pod-failed
branch
from
fb38cbf to
083430a
Compare
|
Can we please add unit test for those newly added utilities. |
viveksinghggits
approved these changes
Nov 14, 2023
KastenMike
reviewed
Nov 14, 2023
| @@ -488,3 +489,59 @@ func GetPodReadyWaitTimeout() time.Duration { | |||
|
|
|||
| return DefaultPodReadyWaitTimeout | |||
| } | |||
|
|
|||
| // getRedactedEnvVariables returns array of variables with removed values | |||
There was a problem hiding this comment.
maybe just add to the comment explaining that this is done because the env vars can contain sensitive info
Done |
pavannd1
reviewed
Nov 14, 2023
| } | ||
| return result | ||
| } | ||
|
|
There was a problem hiding this comment.
We should also redact or hide the command passed into the pod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We have a scenario when invoker can try to create pod with incorrect specification. It would be useful to log what exactly was passed and what pod configuration was built from passed options.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan