-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Postgres tests and remove MariaDB #2370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06be966.
Looks like the mongo-db tests are failing now. |
Signed-off-by: Akanksha Kumari <[email protected]>
if we disable one of the app, the integration test works, I tried disabling MySQL, the test passed commit . https://github.com/kanisterio/kanister/actions/runs/6390938725/job/17345776852, maybe we should upgrade the test infrastructure. |
This reverts commit 7eb9ec4.
I have reverted the commit, that I made in this PR to test the CI. |
pavannd1
commented
Oct 3, 2023
pavannd1
changed the title
Re-enable Postgres tests
Re-enable Postgres tests and remove MariaDB
Oct 3, 2023
akankshakumari393
approved these changes
Oct 4, 2023
leuyentran
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Revert "Temporarily disable Postgres tests (#2367)" This reverts commit 06be966. * Disable mysql app from integration test Signed-off-by: Akanksha Kumari <[email protected]> * Revert "Disable mysql app from integration test" This reverts commit 7eb9ec4. * Remove Maria DB --------- Signed-off-by: Akanksha Kumari <[email protected]> Co-authored-by: Akanksha Kumari <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 06be966.
Additionally, this PR removes MariaDB tests. We will add it back once we have enough resources to run all the tests.
Pull request type
Please check the type of change your PR introduces: