Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PodRunner's RunEx to Run #2369

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Rename PodRunner's RunEx to Run #2369

merged 3 commits into from
Oct 5, 2023

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Oct 2, 2023

Change Overview

Since PodRunner and its usage were successfully refactored, it's time to rename RunEx to Run.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

pavannd1
pavannd1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/kube/pod_runner.go Outdated Show resolved Hide resolved
@e-sumin @pavannd1
Improve readability
f959a63 
Co-authored-by: Pavan Navarathna <[email protected]>
@e-sumin e-sumin added the kueue label Oct 5, 2023
@mergify mergify bot merged commit e01c8eb into master Oct 5, 2023
14 checks passed
@mergify mergify bot deleted the rename-runex-to-run branch October 5, 2023 10:56
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@e-sumin @pavannd1 @mergify
Rename PodRunner's RunEx to Run (#2369)
ea51da6 
* Rename PodRunner's RunEx to Run

* Improve readability

Co-authored-by: Pavan Navarathna <[email protected]>

---------

Co-authored-by: Pavan Navarathna <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@ankitjain235 ankitjain235 Awaiting requested review from ankitjain235

@chaitalisg chaitalisg Awaiting requested review from chaitalisg

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-sumin @pavannd1